Feat: Pendle PT-sUSDe-27Nov25 #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xtj24
commented
Aug 27, 2025
0xtj24
commented
- Add feed, market and ALE tests for Pendle PT sUSDe 27Nov25
08xmt
reviewed
Sep 1, 2025
src/factory/MarketFactory.sol
Outdated
Comment on lines
7
to
11
| IOracle public constant ORACLE = IOracle(0xaBe146CF570FD27ddD985895ce9B138a7110cce8); | ||
| IDolaBorrowingRights public constant DBR = IDolaBorrowingRights(0xAD038Eb671c44b853887A7E32528FaB35dC5D710); | ||
| address public constant GOV = 0x926dF14a23BE491164dCF93f4c468A50ef659D5B; | ||
| address public constant FED = 0x2b34548b865ad66A2B046cb82e59eE43F75B90fd; | ||
| address public constant PAUSE_GUARDIAN = 0xE3eD95e130ad9E15643f5A5f232a3daE980784cd; |
Contributor
There was a problem hiding this comment.
Parameters that may change in the future should be setable by governance.
08xmt
reviewed
Sep 1, 2025
src/factory/FeedSwitchFactory.sol
Outdated
Comment on lines
13
to
14
| uint256 public constant TIMELOCK_PERIOD = 64800; | ||
| address public constant GUARDIAN = 0x4b6c63E6a94ef26E2dF60b89372db2d8e211F1B7; |
Contributor
There was a problem hiding this comment.
Parameters that may change in the future should be setable by governance
08xmt
reviewed
Sep 1, 2025
Contributor
08xmt
left a comment
08xmt
left a comment
There was a problem hiding this comment.
Generally lgtm but would like to see:
- Governance setable params for parameters that may change, as it makes more sense to keep factory in the future than deploy new factories.
- Short test making sure a "manually" deployed market or feed is equivalent to a factory deployed market. Mostly as a way to remind us to update the factory if changes are made to the underlying contracts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.